-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: strange timeseries plot behavior #16461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/tests/plotting/test_series.py
Outdated
@@ -434,6 +434,22 @@ def test_hist_no_overlap(self): | |||
assert len(axes) == 2 | |||
|
|||
@slow | |||
def test_overlapping_datetime(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind moving this to pandas/tests/plotting/test_datetimelike.py
? Seems to fit a bit better there.
Codecov Report
@@ Coverage Diff @@
## master #16461 +/- ##
==========================================
+ Coverage 90.42% 90.42% +<.01%
==========================================
Files 161 161
Lines 51024 51027 +3
==========================================
+ Hits 46139 46142 +3
Misses 4885 4885
Continue to review full report at Codecov.
|
lgtm (failure in CI is already resolved in master). @TomAugspurger this is just a validation test? |
yeah, it was accidentally fixed somewhere along the way, but didn't have a regression test |
@huguesv thanks for taking care of this! (I had meant to but never got around to it, so much appreciated) |
validation tests, closes pandas-dev#6608.
I added a test with the simple repro at the top of bug #6608, which appears to be the missing piece for the bug to be closed.
I went back in time to a previous version of pandas, and I confirmed the issue.