-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add the decimal.Decimal type to infer_dtypes (#15690) #16426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bc15e85
ENH: Add the decimal.Decimal type to infer_dtypes (#15690)
margaret e7e67e8
Reference GH15690 in test_decimals
margaret b291b62
Add enhancement from issue #15690
margaret 024feac
Check that decimal and non-decimal returns 'mixed'
margaret cc9ac39
Fix reference to infer_dtype func
margaret 6f158cb
update infer_dtype docstring with decimal example
margaret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
import collections | ||
import re | ||
from datetime import datetime, date, timedelta, time | ||
from decimal import Decimal | ||
import numpy as np | ||
import pytz | ||
import pytest | ||
|
@@ -462,6 +463,16 @@ def test_floats(self): | |
result = lib.infer_dtype(arr) | ||
assert result == 'floating' | ||
|
||
def test_decimals(self): | ||
# GH15690 | ||
arr = np.array([Decimal(1), Decimal(2), Decimal(3)]) | ||
result = lib.infer_dtype(arr) | ||
assert result == 'decimal' | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, could you add a test with a mix of Decimal and non-decimal (like floats) and make sure that the return is |
||
arr = np.array([1.0, 2.0, Decimal(3)]) | ||
result = lib.infer_dtype(arr) | ||
assert result == 'mixed' | ||
|
||
def test_string(self): | ||
pass | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls update the doc-string & add an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6f158cb