Skip to content

BUG: wide_to_long should check for unique id vars (#16382) #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2017
Merged

BUG: wide_to_long should check for unique id vars (#16382) #16403

merged 4 commits into from
May 23, 2017

Conversation

erikcs
Copy link
Contributor

@erikcs erikcs commented May 20, 2017

Input validation: raise a ValueError in case i does not uniquely identify each row.

@codecov
Copy link

codecov bot commented May 20, 2017

Codecov Report

Merging #16403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16403      +/-   ##
==========================================
+ Coverage   90.41%   90.41%   +<.01%     
==========================================
  Files         161      161              
  Lines       50997    50999       +2     
==========================================
+ Hits        46107    46109       +2     
  Misses       4890     4890
Flag Coverage Δ
#multiple 88.24% <100%> (ø) ⬆️
#single 40.19% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/reshape.py 99.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f55de1...cc46e98. Read the comment docs.

@codecov
Copy link

codecov bot commented May 20, 2017

Codecov Report

Merging #16403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16403      +/-   ##
==========================================
+ Coverage   90.42%   90.42%   +<.01%     
==========================================
  Files         161      161              
  Lines       51023    51026       +3     
==========================================
+ Hits        46138    46141       +3     
  Misses       4885     4885
Flag Coverage Δ
#multiple 88.26% <100%> (ø) ⬆️
#single 40.17% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/reshape.py 99.28% <100%> (ø) ⬆️
pandas/io/formats/style.py 95.92% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a497f...42355cd. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented May 20, 2017

pls add a whatsnew note (bug fix 0.20.2)

@jreback jreback added Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 20, 2017
@jreback jreback added this to the 0.20.2 milestone May 20, 2017
@TomAugspurger TomAugspurger merged commit 04356a8 into pandas-dev:master May 23, 2017
@TomAugspurger
Copy link
Contributor

thanks @Nuffe !

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request May 29, 2017
…andas-dev#16403)

* BUG: wide_to_long should check for unique id vars (pandas-dev#16382)

* Fix uncaught lint error

* Add whatsnew note (bug fix)

(cherry picked from commit 04356a8)
TomAugspurger pushed a commit that referenced this pull request May 30, 2017
* BUG: wide_to_long should check for unique id vars (#16382)

* Fix uncaught lint error

* Add whatsnew note (bug fix)

(cherry picked from commit 04356a8)
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
…andas-dev#16403)

* BUG: wide_to_long should check for unique id vars (pandas-dev#16382)

* Fix uncaught lint error

* Add whatsnew note (bug fix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wide_to_long should verify uniqueness
3 participants