Skip to content

BUG: array raveled but not reshaped in all cases #16375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BUG: array raveled but not reshaped in all cases #16375

wants to merge 1 commit into from

Conversation

RobinFiveWords
Copy link

@RobinFiveWords
Copy link
Author

Sorry about that, not appropriately tested.

@jreback
Copy link
Contributor

jreback commented May 17, 2017

@RobinFiveWords you can reopen and push tests when you are ready

@RobinFiveWords
Copy link
Author

@jreback Thanks, more that my code was bad the first time, didn't understand the full scope of how the function was used. When I update my branch, can I reopen this PR with that new code?

I haven't figured out an elegant way to have maybe_infer_to_datetimelike do exactly what its docstring says, specifically returning the input unchanged. Not sure how important that is, though. I imagine the lib.infer* functions (not sure where in _libs/src to look for them) require a 1-dimensional np.array, and if our input was of higher dimension, we need to reshape exactly once and only after we're done trying to convert. The simplest change, as I see it, is to allow a just-reshaped np.array to be returned in all cases. core/frame.py and core/categorical.py are each going to coerce to np.array in the very next step anyway.

If something readily comes to mind that I'm missing, please let me know!

@RobinFiveWords RobinFiveWords deleted the cast-infer-datetime-reshape-fix branch May 20, 2017 02:46
@TomAugspurger TomAugspurger added this to the No action milestone May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Transpose construction/block error with certain dtypes
3 participants