Skip to content

DOC: Handle missing nbconvert in html build #16330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2017

Conversation

TomAugspurger
Copy link
Contributor

Closes #16329

@TomAugspurger TomAugspurger added this to the 0.21.0 milestone May 11, 2017
@TomAugspurger TomAugspurger mentioned this pull request May 11, 2017
@jreback
Copy link
Contributor

jreback commented May 12, 2017

fine, though to be honest I would just fail and have users install nbconvert its not a big deal. (IIRC its already in the doc-install requirements anyhow).

@jorisvandenbossche
Copy link
Member

Both approaches would be OK for me

@TomAugspurger
Copy link
Contributor Author

Agreed that installing nbconvert isn't a big deal, but since I've already written it this way I'll be lazy and just keep it :)

@TomAugspurger TomAugspurger merged commit 4bdbcb6 into pandas-dev:master May 12, 2017
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
@TomAugspurger TomAugspurger deleted the missing-nbconvert branch May 27, 2017 16:36
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants