BUG: Preserve data order when stacking unsorted levels (#16323) #16325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsm054
force-pushed
the
fix_stack_unsorted_levels
branch
from
5fcb44d to
bd0eda2
Compare
Codecov Report
@@ Coverage Diff @@
## master #16325 +/- ##
==========================================
- Coverage 90.37% 90.35% -0.02%
==========================================
Files 161 161
Lines 50863 50863
==========================================
- Hits 45966 45957 -9
- Misses 4897 4906 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16325 +/- ##
==========================================
- Coverage 90.37% 90.35% -0.03%
==========================================
Files 161 161
Lines 50863 50863
==========================================
- Hits 45966 45955 -11
- Misses 4897 4908 +11
Continue to review full report at Codecov.
|
jreback
added
the
Regression
|
yep seems reasonable. this was an untested case. |
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
May 29, 2017
) (pandas-dev#16325) (cherry picked from commit b1ff291)
TomAugspurger
pushed a commit
that referenced
this pull request
May 30, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the df.stack() problems in #16323-- the levels being used to build the new index were those of the original frame, which fails when the levels get sorted.
git diff upstream/master --name-only -- '*.py' | flake8 --diff