-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: select_as_multiple doesn't respect start/stop kwargs GH16209 #16317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4186,6 +4186,20 @@ def test_start_stop_table(self): | |
expected = df.loc[30:40, ['A']] | ||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_start_stop_multiple(self): | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add the issue number as a comment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add the issue number |
||
with ensure_clean_store(self.path) as store: | ||
|
||
df = DataFrame({"foo": [1, 2], "bar": [1, 2]}) | ||
|
||
store.append_to_multiple({'selector': ['foo'], 'data': None}, df, | ||
selector='selector') | ||
result = store.select_as_multiple(['selector', 'data'], | ||
selector='selector', start=0, | ||
stop=1) | ||
expected = df[['foo', 'bar']].iloc[[0]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_start_stop_fixed(self): | ||
|
||
with ensure_clean_store(self.path) as store: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can put this in 0.20.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this