Skip to content

Add tests for Excel styling that were missing #16313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2017

Conversation

jnothman
Copy link
Contributor

@jnothman jnothman commented May 9, 2017

It seems these cases were untested by accident when styler to excel conversion was recently added.

  • tests added / passed
  • passes git diff upstream/master --name-only -- '*.py' | flake8 --diff

@codecov
Copy link

codecov bot commented May 10, 2017

Codecov Report

Merging #16313 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16313      +/-   ##
==========================================
- Coverage   90.39%   90.35%   -0.05%     
==========================================
  Files         161      161              
  Lines       50863    50863              
==========================================
- Hits        45978    45956      -22     
- Misses       4885     4907      +22
Flag Coverage Δ
#multiple 88.13% <ø> (-0.03%) ⬇️
#single 40.33% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/core/frame.py 97.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81aa70c...962df50. Read the comment docs.

@codecov
Copy link

codecov bot commented May 10, 2017

Codecov Report

Merging #16313 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16313      +/-   ##
==========================================
- Coverage   90.39%   90.35%   -0.05%     
==========================================
  Files         161      161              
  Lines       50863    50863              
==========================================
- Hits        45978    45956      -22     
- Misses       4885     4907      +22
Flag Coverage Δ
#multiple 88.13% <ø> (-0.03%) ⬇️
#single 40.33% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/core/frame.py 97.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81aa70c...962df50. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone May 10, 2017
@jreback jreback added IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite labels May 10, 2017
@jreback jreback merged commit 09d1c97 into pandas-dev:master May 10, 2017
@jreback
Copy link
Contributor

jreback commented May 10, 2017

thanks!

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants