Skip to content

DOC: tm.assert_almost_equal() check_exact param defaults to False in code & docstring #16265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

winklerand
Copy link
Contributor

  • passes git diff upstream/master --name-only -- '*.py' | flake8 --diff

Parameter check_exact defaults to False whereas the docstring indicated True.

@winklerand winklerand changed the title DOC: tm.assert_almost_equal() check_exact param defaults to False DOC: tm.assert_almost_equal() check_exact param defaults to False in code & docstring May 6, 2017
@codecov
Copy link

codecov bot commented May 6, 2017

Codecov Report

Merging #16265 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16265      +/-   ##
==========================================
- Coverage   90.33%    90.3%   -0.04%     
==========================================
  Files         167      167              
  Lines       50907    50907              
==========================================
- Hits        45989    45972      -17     
- Misses       4918     4935      +17
Flag Coverage Δ
#multiple 88.09% <ø> (-0.02%) ⬇️
#single 40.29% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 78.87% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/core/frame.py 97.58% <0%> (-0.1%) ⬇️
pandas/_version.py 44.65% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e513430...6d98fe4. Read the comment docs.

@jorisvandenbossche jorisvandenbossche added this to the 0.21.0 milestone May 6, 2017
@jorisvandenbossche jorisvandenbossche merged commit ba60321 into pandas-dev:master May 6, 2017
@jorisvandenbossche
Copy link
Member

@winklerand Thanks!

@winklerand winklerand deleted the DOC-check-exact-docstring-wrong branch May 6, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants