DOC: Add redirect for moved classes #16200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new redirects in this commit are for Resampler and Styler Refactor how we do redirects. Moved all the logic into the config file, where you state the methods / classes to be redirected. Removed all the logic from the template, and just look up in the new html_context variable. Closes pandas-dev#16186
TomAugspurger
force-pushed
the
api-redirect
branch
from
bb40fa9 to
635d770
Compare
|
Redirects on my local build look OK. |
jorisvandenbossche
approved these changes
May 2, 2017
doc/source/conf.py
Outdated
| mod, classname = new.rsplit('.', 1) | ||
| klass = getattr(importlib.import_module(mod), classname) | ||
| methods = [x for x in dir(klass) | ||
| if not x.startswith('_') or x.startswith('__')] |
There was a problem hiding this comment.
The first check already covers the second?
There was a problem hiding this comment.
the second is to include the __ methods. We have http://pandas.pydata.org/pandas-docs/stable/generated/pandas.tseries.resample.Resampler.__iter__.html
I could just whitelist __iter__... We document that and __array__ on Categorical.
Codecov Report
@@ Coverage Diff @@
## master #16200 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 162 162
Lines 50871 50871
=======================================
Hits 46225 46225
Misses 4646 4646
Continue to review full report at Codecov.
|
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
* DOC: Add redirect for moved classes The new redirects in this commit are for Resampler and Styler Refactor how we do redirects. Moved all the logic into the config file, where you state the methods / classes to be redirected. Removed all the logic from the template, and just look up in the new html_context variable. Closes pandas-dev#16186 * Only redirect for used dunder methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new redirects in this commit are for Resampler and Styler
Refactor how we do redirects. Moved all the logic into the
config file, where you state the methods / classes to be redirected.
Removed all the logic from the template, and just look up in the
new html_context variable.
Closes #16186
Running a test locally ATM.