Skip to content

Update docs.ecosystem.api.pandasdmx #16172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dr-leo
Copy link
Contributor

@dr-leo dr-leo commented Apr 29, 2017

I am the author of pandaSDMX and contributed the section about two years ago. It is outdated and has become misleading.

  • tests added / passed
  • passes git diff upstream/master --name-only -- '*.py' | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Apr 29, 2017

Codecov Report

Merging #16172 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16172      +/-   ##
==========================================
+ Coverage   90.86%   90.88%   +0.02%     
==========================================
  Files         162      162              
  Lines       50819    50819              
==========================================
+ Hits        46177    46188      +11     
+ Misses       4642     4631      -11
Flag Coverage Δ
#multiple 88.66% <ø> (+0.02%) ⬆️
#single 40.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a0574...ec3801a. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 29, 2017

Codecov Report

Merging #16172 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16172      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         162      162              
  Lines       50819    50827       +8     
==========================================
+ Hits        46177    46183       +6     
- Misses       4642     4644       +2
Flag Coverage Δ
#multiple 88.64% <ø> (-0.01%) ⬇️
#single 40.33% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/compat/__init__.py 62.22% <0%> (-0.11%) ⬇️
pandas/core/generic.py 91.63% <0%> (ø) ⬆️
pandas/core/config_init.py 94.52% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a0574...d97e006. Read the comment docs.

the European statistics office (Eurostat)
and the European Central Bank (ECB). Datasets may be returned as pandas Series
or multi-indexed DataFrames.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer just a link back to the package readme where you can update.

@dr-leo
Copy link
Contributor Author

dr-leo commented May 1, 2017 via email

@TomAugspurger TomAugspurger merged commit 096e215 into pandas-dev:master May 1, 2017
@TomAugspurger
Copy link
Contributor

Thanks, I'll have to check out your project next time I use eurostat :)

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
* Update docs.ecosystem.api.pandasdmx

* Remove links to data providers

* Removed references to data providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants