Skip to content

CLN: remove unused TimeGrouper._get_binner_for_resample() method #16152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

winklerand
Copy link
Contributor

  • tests passed
  • passes git diff upstream/master --name-only -- '*.py' | flake8 --diff
  • whatsnew entry

method seems unused and is not covered by tests -> remove it?

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #16152 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16152      +/-   ##
==========================================
+ Coverage   90.83%   90.85%   +0.01%     
==========================================
  Files         159      159              
  Lines       50796    50785      -11     
==========================================
  Hits        46143    46143              
+ Misses       4653     4642      -11
Flag Coverage Δ
#multiple 88.64% <ø> (+0.01%) ⬆️
#single 40.32% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/resample.py 96.06% <ø> (+1.6%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b80ed3...465e555. Read the comment docs.

@jreback jreback added the Clean label Apr 27, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 27, 2017
@jreback
Copy link
Contributor

jreback commented Apr 27, 2017

thanks, don't remember fully what I added this.

@jreback jreback merged commit 2d9909c into pandas-dev:master Apr 27, 2017
@jreback
Copy link
Contributor

jreback commented Apr 27, 2017

this was replaced by _get_binner which dispatched to the correct subclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants