-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
MAINT: Remove self.assertFalse from testing #16151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
316eb82
to
ecc0590
Compare
One remark for this replacement: in certain cases it might be that we want to test that something is actually |
@jorisvandenbossche : Well according to |
Ah, you're correct. The implementation actually just does |
@gfyoung you're a hero for running through all these! |
@MaximilianR : Thanks! Couldn't do it without bash ;) |
Codecov Report
@@ Coverage Diff @@
## master #16151 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 159 159
Lines 50796 50796
=======================================
Hits 46143 46143
Misses 4653 4653
Continue to review full report at Codecov.
|
thanks! |
Title is self-explanatory.
Partially addresses #15990.