DEPR: provide deprecations and exposure for NaTType

[jreback]

xref #16137

[codecov]

Codecov Report

Merging #16146 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #16146   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         159      159           
  Lines       50796    50796           
=======================================
  Hits        46143    46143           
  Misses       4653     4653

Flag	Coverage Δ
#multiple	88.62% <ø> (ø)	⬆️
#single	40.31% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/tslib.py	100% <ø> (ø)	⬆️
pandas/__init__.py	92.3% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b80ed3...cd2d9ce. Read the comment docs.

[TomAugspurger]

Currently, under the main module privacy changes table we have

• The function union_categoricals() is now importable from pandas.api.types, formerly from pandas.types.concat (GH15998)

Do you want to add an entry for NaTTYpe is not importable from pandas.api.types?

[jreback]

Do you want to add an entry for NaTTYpe is not importable from pandas.api.types?
sure

[jorisvandenbossche]

@jreback Have you seen the comment of @shoyer on the issue?

The right way to use this going forward is probably type(pd.NaT). I'm not sure what the point of exposing NaTType is, given that it's a singleton. Python 2 had types.NoneType but they removed it in Python 3.

I think that makes sense, and thus it is maybe not needed to expose this publicly (we can also say to use that in the deprecation message)

[jreback]

if u look at the PR that's exactly what i did

[jreback]

it's in the deprecation message

[jreback]

@jorisvandenbossche

[jorisvandenbossche]

Whoops :-)
That's what you get from rebasing instead of adding a new commit, as there was no notification of a change, I supposed it was the original state that was merged :-)