-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG/API: Catch exceptions in _ipython_display_ #16132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/API: Catch exceptions in _ipython_display_ #16132
Conversation
We raise an UnserializeableWarning when we fail to generate the table schema and do not publish a `table_schema` repr.
cc @rgbkrk so users get a |
Codecov Report
@@ Coverage Diff @@
## master #16132 +/- ##
==========================================
- Coverage 90.86% 90.84% -0.03%
==========================================
Files 159 159
Lines 50771 50777 +6
==========================================
- Hits 46133 46126 -7
- Misses 4638 4651 +13
Continue to review full report at Codecov.
|
Looks good to me, this is completely appropriate behavior and informs the user as to what happened better than before. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm merge away
Small question: is it worth to add a special Warning for this (instead of using just UserWarning)? In the sense that, if we intend to actually solve this issue in an upcoming release (certainly if we want this as the default repr this will be needed), then it is maybe not needed to add the special class (which we have to keep for compat afterwards). |
Yeah, I went back and forth on this. In the end I went with a special warning since we may always have some things that can't be represented with the spec (maybe), and it's a bit easier to filter just this warning if you want. I'm open to changing it to a builtin warning though. |
We raise an UnserializeableWarning when we fail to generate the table schema and do not publish a `table_schema` repr.
We raise an UnserializeableWarning when we fail to generate
the table schema and do not publish a
table_schema
repr.closes #15996