Skip to content

REGR: bug in moments when using bottleneck #16124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 25, 2017

closes #16116

@jreback jreback added Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version labels Apr 25, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 25, 2017
@TomAugspurger
Copy link
Contributor

Do nanskew, nankurt, and nansem need the same fix too?

@jreback
Copy link
Contributor Author

jreback commented Apr 25, 2017

done (nansem already hits the nanvar path).

I had changed this code a long time ago (but in 0.20.0) IIRC to simplify. Guess was not fully exercised.

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #16124 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16124      +/-   ##
==========================================
+ Coverage   90.83%   90.84%   +<.01%     
==========================================
  Files         159      159              
  Lines       50771    50774       +3     
==========================================
+ Hits        46120    46124       +4     
+ Misses       4651     4650       -1
Flag Coverage Δ
#multiple 88.62% <100%> (ø) ⬆️
#single 40.33% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/nanops.py 98.18% <100%> (+0.01%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca4fca...15afc09. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit 6ad32d2 into pandas-dev:master Apr 25, 2017
@jorisvandenbossche
Copy link
Member

Thanks!

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG 0.20.0rc1: Empty series for var/std for frame with non-numeric columns
3 participants