BUG: Compare names with None in DataFrame ctor #16117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Bug
Dtype Conversions
(this was present in 0.19.2)
jorisvandenbossche
approved these changes
Apr 24, 2017
Codecov Report
@@ Coverage Diff @@
## master #16117 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.01%
==========================================
Files 159 159
Lines 50771 50771
==========================================
- Hits 46122 46120 -2
- Misses 4649 4651 +2
Continue to review full report at Codecov.
|
jreback
reviewed
Apr 24, 2017
| @@ -1727,4 +1727,5 @@ Other | |||
| - Compat with SciPy 0.19.0 for testing on ``.interpolate()`` (:issue:`15662`) | |||
| - Compat for 32-bit platforms for ``.qcut/cut``; bins will now be ``int64`` dtype (:issue:`14866`) | |||
| - Bug in interactions with ``Qt`` when a ``QtApplication`` already exists (:issue:`14372`) | |||
| - Bug in DataFrame constructor failing to handle dtypes with passed a Series with a falsey name (:issue:`16114`) | |||
There was a problem hiding this comment.
you don't need a whats new if its not actually a change (and I don't think it is)
|
aside from the whatsnew lgtm. |
|
thanks! |
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
Closes pandas-dev#16114 Author: Tom Augspurger <[email protected]> Closes pandas-dev#16117 from TomAugspurger/int_dtypes and squashes the following commits: 7f7a32e [Tom Augspurger] DOC: Add a release note 0663098 [Tom Augspurger] BUG: Compare names with None in DataFrame ctor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16114