REGR: assure .unique of mixed strings does not stringize #16108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Regression
|
ok this doesn't regress performance (and helps in a couple of situations). |
jreback
force-pushed
the
unique_nan
branch
3 times, most recently
from
3962e10 to
93cf83a
Compare
Codecov Report
@@ Coverage Diff @@
## master #16108 +/- ##
==========================================
+ Coverage 90.83% 90.83% +<.01%
==========================================
Files 159 159
Lines 50768 50771 +3
==========================================
+ Hits 46117 46120 +3
Misses 4651 4651
Continue to review full report at Codecov.
|
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16107
this might slow things down (because of the inferring), so will have to make a fix for that.