Unary plus operator (Issue #16073) #16106

wuisawesome · 2017-04-24T07:27:48Z

closes Unary plus missing for Series and DataFrame #16073
tests added / passed
passes git diff upstream/master --name-only -- '*.py' | flake8 --diff
whatsnew entry

Continuation from #16103.

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes.

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes. Edits "What's new" to reflect the new feature

…nto unary_plus_operator

jreback · 2017-04-24T10:06:21Z

pandas/tests/series/test_operators.py

@@ -91,6 +91,9 @@ def check(series, other, check_reverse=False):
        check(self.ts, 5, check_reverse=True)
        check(tm.makeFloatSeries(), tm.makeFloatSeries(), check_reverse=True)

+    def test_pos(self):
+       assert_series_equal(+self.series, 1 * self.series)  #Ensures no rounding issues


comment is not necessary

jreback · 2017-04-24T10:06:45Z

pandas/tests/series/test_operators.py

@@ -91,6 +91,9 @@ def check(series, other, check_reverse=False):
        check(self.ts, 5, check_reverse=True)
        check(tm.makeFloatSeries(), tm.makeFloatSeries(), check_reverse=True)

+    def test_pos(self):
+       assert_series_equal(+self.series, 1 * self.series)  #Ensures no rounding issues
+


add a couple of raise assertion on strings

this would technically work on datetimes, but I think we should disallow this (pls add tests for __neg__ as well).

e.g.

In [9]: -Series(list('abc')) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-9-93660e79330e> in <module>() ----> 1 -Series(list('abc')) /Users/jreback/pandas/pandas/core/generic.py in __neg__(self) 865 arr = operator.inv(values) 866 else: --> 867 arr = operator.neg(values) 868 return self.__array_wrap__(arr) 869 TypeError: bad operand type for unary -: 'str'

In [10]: Series(pd.date_range('20130101', periods=3)) Out[10]: 0 2013-01-01 1 2013-01-02 2 2013-01-03 dtype: datetime64[ns] In [11]: -Series(pd.date_range('20130101', periods=3)) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-11-23bfb90f61eb> in <module>() ----> 1 -Series(pd.date_range('20130101', periods=3)) /Users/jreback/pandas/pandas/core/generic.py in __neg__(self) 865 arr = operator.inv(values) 866 else: --> 867 arr = operator.neg(values) 868 return self.__array_wrap__(arr) 869 TypeError: ufunc 'negative' did not contain a loop with signature matching types dtype('<M8[ns]') dtype('<M8[ns]') In [12]: +Series(pd.date_range('20130101', periods=3)) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-12-b72a11ca274c> in <module>() ----> 1 +Series(pd.date_range('20130101', periods=3)) TypeError: bad operand type for unary +: 'Series'

I want [12] still to raise after this change.

jreback · 2017-04-24T10:21:49Z

doc/source/whatsnew/v0.20.0.txt

@@ -1196,6 +1195,8 @@ Other API Changes
 - ``DataFrame`` and ``Panel`` constructors with invalid input will now raise ``ValueError`` rather than ``pandas.core.common.PandasError``, if called with scalar inputs and not axes; The exception ``PandasError`` is removed as well. (:issue:`15541`)
 - The exception ``pandas.core.common.AmbiguousIndexError`` is removed as it is not referenced (:issue:`15541`)

+- `Series` and `DataFrame` now have unary plus operators (:issue:`16073`). The plus operator behaves consistently with the unary minus operator. 


use double backticks here around Series, DataFrame. Put the issue reference at the end.

jreback · 2017-04-24T10:22:03Z

doc/source/whatsnew/v0.20.0.txt

@@ -213,8 +213,7 @@ See :ref:`the docs here <io.pickle.compression>`

 Using an explicit compression type

-.. ipython:: python


don't change other things in the file

I'm not certain why this happened. The rest of the diff shows that the same identical line is added again, thus making no actual changes to the file

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes. Edits "What's new" to reflect the new feature

Updated plus operator edge case. Datatype that implement + but not - should not be able to use + to maintain symmetry Rewrites tests to work better with strings and other non numeric datatypes that implement `*` operator

…ator

wuisawesome · 2017-04-24T21:58:21Z

Hopefully I've addressed all your concerns and rebased.

jreback · 2017-04-25T02:25:48Z

pandas/tests/frame/test_operators.py

@@ -343,9 +343,15 @@ def test_logical_with_nas(self):
        expected = Series([True, True])
        assert_series_equal(result, expected)

+    def test_pos(self):
+        try:
+            assert_frame_equal(+self.frame, self.frame.apply(lambda x: +self.frame))


dont' test like this. instead use a couple of sample frames that have singular dtypes (can be a single column). test the valid ones via assert_frame_equal(-frame, -1 * frame). The invalid ones should raise.

jreback · 2017-04-25T02:25:53Z

pandas/tests/series/test_operators.py

+       try:
+           assert_series_equal(+self.series, self.series.apply(lambda x: +x))
+       except TypeError:
+           if not (len(self.frame) > 0 and isinstance(self.frame[0], pd.Timestampe)):


jreback · 2017-04-25T02:27:53Z

pandas/core/generic.py

@@ -859,6 +859,19 @@ def _indexed_same(self, other):
        return all([self._get_axis(a).equals(other._get_axis(a))
                    for a in self._AXIS_ORDERS])

+    def __pos__(self):
+        values = _values_from_object(self)
+        if values.dtype == np.bool_:


something like:

if is_bool_dtype(values): ... elif not (is_numeric_dtype(values) or is_timedelta64_dtype(values)): raise

add the same logic to __neg__

jreback · 2017-05-13T21:40:26Z

can you rebase / update

jreback · 2017-05-19T01:11:31Z

can you move whatsnew & rebase / update

jreback · 2017-08-01T22:57:23Z

closing as stale. if you want to re-visit, pls comment and we can re-open.

wuisawesome added 4 commits April 23, 2017 23:40

ENH: Unary plus operator, deals with issue #16073

7e71501

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes.

What's new

af7512a

ENH: Unary plus operator, deals with issue #16073

38d48c8

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes. Edits "What's new" to reflect the new feature

Merge branch 'unary_plus_operator' of github.com:wuisawesome/pandas i…

2ec64d2

…nto unary_plus_operator

wuisawesome mentioned this pull request Apr 24, 2017

Unary plus feature #16103

Closed

jreback added Compat pandas objects compatability with Numpy or Python functions Numeric Operations Arithmetic, Comparison, and Logical operations labels Apr 24, 2017

jreback requested changes Apr 24, 2017

View reviewed changes

wuisawesome added 6 commits April 24, 2017 11:37

ENH: Unary plus operator, deals with issue #16073

f10e3be

Overrides `+` operator, providing consistent behavior with `-`. Creates tests for the new operator for series and dataframes. Edits "What's new" to reflect the new feature

Operator edge cases, better tests

2c09624

Updated plus operator edge case. Datatype that implement + but not - should not be able to use + to maintain symmetry Rewrites tests to work better with strings and other non numeric datatypes that implement `*` operator

Merge remote-tracking branch 'pandas-dev/master' into unary_plus_oper…

8f4d7ca

…ator

Added double ticks to whats new

c658f7f

Merging

d932379

Merge remote-tracking branch 'pandas-dev/master' into unary_plus_oper…

0ab9979

…ator

jreback requested changes Apr 25, 2017

View reviewed changes

jreback closed this Aug 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unary plus operator (Issue #16073) #16106

Unary plus operator (Issue #16073) #16106

wuisawesome commented Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

jreback Apr 24, 2017

wuisawesome Apr 24, 2017

wuisawesome commented Apr 24, 2017

jreback Apr 25, 2017

jreback Apr 25, 2017

jreback Apr 25, 2017

jreback Apr 25, 2017

jreback commented May 13, 2017

jreback commented May 19, 2017

jreback commented Aug 1, 2017

		@@ -213,8 +213,7 @@ See :ref:`the docs here <io.pickle.compression>`

		Using an explicit compression type

		.. ipython:: python

Unary plus operator (Issue #16073) #16106

Unary plus operator (Issue #16073) #16106

Conversation

wuisawesome commented Apr 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wuisawesome commented Apr 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented May 13, 2017

jreback commented May 19, 2017

jreback commented Aug 1, 2017