Skip to content

BLD: 3.6.1 ABI compat #16066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2017
Merged

BLD: 3.6.1 ABI compat #16066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/_libs/src/compat_helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,19 @@ The full license is in the LICENSE file, distributed with this software.
PySlice_GetIndicesEx changes signature in PY3
but 3.6.1 in particular changes the behavior of this function slightly
https://bugs.python.org/issue27867


In 3.6.1 PySlice_GetIndicesEx was changed to a macro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @njsmith

?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it does what you're hoping it does to me.

inadvertently breaking ABI compat. For now, undefing
the macro, which restores compat.
https://github.com/pandas-dev/pandas/issues/15961
https://bugs.python.org/issue29943
*/

#if PY_VERSION_HEX < 0x03070000 && defined(PySlice_GetIndicesEx)
#undef PySlice_GetIndicesEx
#endif

PANDAS_INLINE int slice_get_indices(PyObject *s,
Py_ssize_t length,
Py_ssize_t *start,
Expand Down