Skip to content

CLN: update pandas.lib deprecation messages (GH15936) #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2017

Conversation

jorisvandenbossche
Copy link
Member

Closes #15936

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Apr 16, 2017
lib = _DeprecatedModule(deprmod='pandas.lib', deprmodto=False,
moved={'Timestamp': 'pandas.Timestamp',
'Timedelta': 'pandas.Timedelta',
'NaT': 'pandas.NaT',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in .types now (i removed .lib)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I first thought that as well, but it is not the case in master: https://github.com/pandas-dev/pandas/blob/master/pandas/api/lib/__init__.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't remove that file which is not distributed - look in types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow ..

It is also not in types: https://github.com/pandas-dev/pandas/blob/master/pandas/api/types/__init__.py

and why shouldn't the file be removed if we don't use it?

@codecov
Copy link

codecov bot commented Apr 16, 2017

Codecov Report

Merging #16021 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16021      +/-   ##
==========================================
- Coverage      91%   90.99%   -0.01%     
==========================================
  Files         153      153              
  Lines       50481    50483       +2     
==========================================
  Hits        45938    45938              
- Misses       4543     4545       +2
Flag Coverage Δ
#multiple 88.76% <83.33%> (-0.01%) ⬇️
#single 40.44% <16.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/__init__.py 93.02% <100%> (ø) ⬆️
pandas/util/depr_module.py 79.06% <80%> (-1.42%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3119e90...ad5d4b3. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Apr 16, 2017

I though I had moved this (I may have changed some documents somewhere). Can you do it. remove api.lib and just put .infer_dtype into .api.types (and remove .lib)

@jreback jreback merged commit a25272b into pandas-dev:master Apr 16, 2017
@jreback
Copy link
Contributor

jreback commented Apr 16, 2017

I'll do a separate PR to move infer_dtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants