-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: update pandas.lib deprecation messages (GH15936) #16021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: update pandas.lib deprecation messages (GH15936) #16021
Conversation
lib = _DeprecatedModule(deprmod='pandas.lib', deprmodto=False, | ||
moved={'Timestamp': 'pandas.Timestamp', | ||
'Timedelta': 'pandas.Timedelta', | ||
'NaT': 'pandas.NaT', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is in .types now (i removed .lib)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I first thought that as well, but it is not the case in master: https://github.com/pandas-dev/pandas/blob/master/pandas/api/lib/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't remove that file which is not distributed - look in types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow ..
It is also not in types: https://github.com/pandas-dev/pandas/blob/master/pandas/api/types/__init__.py
and why shouldn't the file be removed if we don't use it?
Codecov Report
@@ Coverage Diff @@
## master #16021 +/- ##
==========================================
- Coverage 91% 90.99% -0.01%
==========================================
Files 153 153
Lines 50481 50483 +2
==========================================
Hits 45938 45938
- Misses 4543 4545 +2
Continue to review full report at Codecov.
|
I though I had moved this (I may have changed some documents somewhere). Can you do it. remove |
I'll do a separate PR to move infer_dtype |
Closes #15936