Merge multi-index with a multi-index #15980
Conversation
Allow the merging of multi-indexed objects with different number of levels
Merge multi-index with a multi-index
|
you only need 1 PR if u have changes just push to the same one |
|
Sorry Jeff, I'm just not very experienced with GIT. Thanks for the tip |
pandas/indexes/base.py
Outdated
|
|
||
| def _complete_join(new_lvls, new_lbls, new_nms): |
There was a problem hiding this comment.
first thing is that you must have exactly the same levels that match, otherwise this is a raise. They must match in number and name (or None matches None).
There was a problem hiding this comment.
The common levels are specified by: overlap = list(set(self_names) & set(other_names)).
I think this way guarantees that they will much in number and name. Am I missing something?
| @@ -1224,7 +1220,7 @@ def f(): | |||
| expected = ( | |||
| DataFrame(dict( | |||
| household_id=[1, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3, 4], | |||
| asset_id=["nl0000301109", "nl0000289783", "gb00b03mlx29", | |||
There was a problem hiding this comment.
I think this is a typo in the original test. I am quite sure because the deleted ID (nl0000289783) does not appear in any dataframe of 'test_join_multi_levels2' function.
| TripPurp=['hbw', 'nhb', 'hbo', 'nhb', 'hbw'], | ||
| Trips=[1987, 3647, 2470, 4296, 4444], | ||
| Distance=[100, 80, 90, np.nan, 75]), | ||
| columns=['Origin', 'Destination', 'Period', 'TripPurp', |
There was a problem hiding this comment.
so the very first test you should have is a self-join.
There was a problem hiding this comment.
Do you mean result = matrix.join(matrix, how='inner', rsuffix='_joined')
|
this needs quite a bit more testing. Would need to exercise all of the |
|
Extra tests have been added. |
| TripPurp=['hbw', 'nhb', 'hbo', 'nhb', 'hbw'], | ||
| Trips=[1987, 3647, 2470, 4296, 4444], | ||
| Distance=[100, 80, 90, np.nan, 75]), | ||
| columns=['Origin', 'Destination', 'Period', 'TripPurp', |
There was a problem hiding this comment.
Hi @jreback , I've implemented the requested changes but I'm not sure they show because I force-pushed.
There was a problem hiding this comment.
nothing seems to have been pushed.
There was a problem hiding this comment.
Nevertheless, the current commit includes all the requested changes. You can review them whenever possible
There was a problem hiding this comment.
if it was pushed it would show up
there are 2 commits last one from april 12
There was a problem hiding this comment.
I think now it must be fine. My changes were pushed in a second commit but now I merged them. Really sorry about the confusion, still getting to know GIT..
Allow the merging of multi-indexed objects with different number of levels
Allow the merging of multi-indexed objects with different number of levels
Conflicts: pandas/indexes/base.py pandas/tests/tools/test_merge.py
Allow the merging of multi-indexed objects with different number of levels
|
@harisbal I see you are pushing this, but you need to resolve the conflicts. |
Allow the merging of multi-indexed objects with different number of levels
Allow the merging of multi-indexed objects with different number of levels
|
This PR is a mess. I'll read the docs more carefully and create a new clean PR. Apologies about all the trouble I've caused |
#6360
Allow the merging of multi-indexed objects with different number of levels.
During tests I receive the following error: pandas/pandas/core/internals.py:4800: ComplexWarning: Casting complex values to real discards the imaginary part