BUG: Fix MultiIndex names handling in pd.concat #15955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix attempt for issue pandas-dev#15787. The discrepancy between definition and corresponding implementation of so-called non-none names in function _get_consensus_names leads to this bug.
jreback
reviewed
Apr 9, 2017
pandas/tests/tools/test_concat.py
Outdated
| df = pd.DataFrame({'col': range(5)}, index=index) | ||
|
|
||
| result = concat([df, df], keys=[1, 2], names=['level2']) | ||
| result = result.index.names |
There was a problem hiding this comment.
I would rather you actually construct the expected DF here (and use assert_frame_equal
Codecov Report
@@ Coverage Diff @@
## master #15955 +/- ##
==========================================
- Coverage 91% 91% -0.01%
==========================================
Files 145 145
Lines 49576 49581 +5
==========================================
+ Hits 45118 45121 +3
- Misses 4458 4460 +2
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Apr 10, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix attempt for issue #15787.
The discrepancy between definition and corresponding implementation of so-called non-none names in function _get_consensus_names leads to this bug.
git diff upstream/master --name-only -- '*.py' | flake8 --diff