BUG: Standardize malformed row handling in Python engine #15913
Conversation
pandas/io/parsers.py
Outdated
| elif 'newline inside string' in msg: | ||
| msg = ('EOF inside string starting with ' | ||
| 'line ' + str(kwargs['row_num'])) | ||
| raise Exception(msg) |
There was a problem hiding this comment.
this is a plain Exception? shouldn't it be a ValueError?
There was a problem hiding this comment.
Copied from where it was originally, which according to the blame was refactored by you! 😄
In any case, I agree: we should just remove that line and raise csv.Error now
There was a problem hiding this comment.
yeah csv.Error sounds fine
make a note of this in the whatsnew though
Codecov Report
@@ Coverage Diff @@
## master #15913 +/- ##
==========================================
+ Coverage 90.95% 90.96% +<.01%
==========================================
Files 145 145
Lines 49534 49531 -3
==========================================
- Hits 45056 45055 -1
+ Misses 4478 4476 -2
Continue to review full report at Codecov.
|
gfyoung
force-pushed
the
invalid-quote-skipfooter
branch
from
e0157d6 to
884387e
Compare
|
@jreback : Everything is green and ready to go. |
|
thanks @gfyoung |
Wrap
next(source)whensourceis a file-buffer object to allow for more uniform error message displaying in the Python engine. Closes #15910.