BUG: Patch handling no NA values in TextFileReader #15881
Conversation
doc/source/whatsnew/v0.20.0.txt
Outdated
| @@ -1011,6 +1011,7 @@ I/O | |||
| - Bug in ``DataFrame.to_stata()`` and ``StataWriter`` which produces incorrectly formatted files to be produced for some locales (:issue:`13856`) | |||
| - Bug in ``StataReader`` and ``StataWriter`` which allows invalid encodings (:issue:`15723`) | |||
| - Bug in ``pd.to_json()`` for the C engine where rollover was not correctly handled for case where frac is odd and diff is exactly 0.5 (:issue:`15716`, :issue:`15864`) | |||
| - Bug in ``pd.read_csv()`` when an index was specified and no values were specified as null values (:issue:`15835`) | |||
There was a problem hiding this comment.
put with the other pd.read_csv bugs (at the top of this section, IIRC)
There was a problem hiding this comment.
Based on your comment below, I'll leave this alone, but yes, you are correct that the rest are at the top of this section.
There was a problem hiding this comment.
yep, basically just trying to organize these for easy reading. IOW, trying to put similar reports next to each other if possible.
There was a problem hiding this comment.
Having had to patch my test (comment below), I fixed this too.
|
lgtm. I can fix the whatsnew on merge. |
|
interesting this breaks some tests. |
Yeah, that's the test I just wrote :/ Hmm...need to figure this out. |
gfyoung
force-pushed
the
keep-default-na-excel
branch
from
ff7eb61 to
0bb6f64
Compare
| @@ -995,6 +995,7 @@ I/O | |||
| - Bug in ``pd.read_csv()`` for the C engine where ``usecols`` were being indexed incorrectly with ``parse_dates`` (:issue:`14792`) | |||
| - Bug in ``pd.read_csv()`` with ``parse_dates`` when multiline headers are specified (:issue:`15376`) | |||
| - Bug in ``pd.read_csv()`` with ``float_precision='round_trip'`` which caused a segfault when a text entry is parsed (:issue:`15140`) | |||
| - Bug in ``pd.read_csv()`` when an index was specified and no values were specified as null values (:issue:`15835`) | |||
|
random failure on osx build so I restarted. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #15881 +/- ##
==========================================
- Coverage 90.99% 90.97% -0.02%
==========================================
Files 143 143
Lines 49477 49477
==========================================
- Hits 45020 45011 -9
- Misses 4457 4466 +9
Continue to review full report at Codecov.
|
|
@jreback : All green and ready to merge. |
|
thanks! |
When cleaning
na_valuesduring initialization ofTextFileReader, we return alistwhenever we specify thatna_valuesshould be empty. However, the rest of the code expects aset.Closes #15835.