COMPAT: NaT support tz_localize / tz_convert (#15830) #15868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15868 +/- ##
==========================================
- Coverage 90.98% 90.96% -0.02%
==========================================
Files 143 143
Lines 49449 49449
==========================================
- Hits 44992 44983 -9
- Misses 4457 4466 +9
Continue to review full report at Codecov.
|
jreback
reviewed
Apr 2, 2017
pandas/_libs/tslib.pyx
Outdated
| @@ -845,6 +845,12 @@ class NaTType(_NaT): | |||
| # GH 10939 | |||
| return np.nan | |||
|
|
|||
| def tz_localize(self): | |||
| return NPY_NAT | |||
There was a problem hiding this comment.
this is not necessary (that's the point of the _nat_methods code below
|
can you add a whatsnew note as well (add this issue number next to #15782 in the whatsnew) |
jreback
added
Missing-data
|
Thanks, I erased the unnecessary methods and add the wathsnew note |
|
thanks @atbd nice PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15830
git diff upstream/master --name-only -- '*.py' | flake8 --diff