-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Citing source in README file #15856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For GH users who strictly or heavily use the web-view instead of a local Git, having a direct link is handy, as it does not require downloading the PDF _if_ the user wanted to go to the source of it directly. It's an alternative that allows those interested in more uploads similar to this PDF from the same author(s).
You linked to the R cheatsheet (on which the pandas one is based). Was that on purpose? |
actually I think this is reasonable, though I think the wording should be that this is referenced/based on the dplyr sheet. |
I re-read the PDF and made sure the wording reflected the content presented. I also changed the source-citing so that is more friendly for .TXT files instead of Markdown or unspecified.
@jorisvandenbossche Good catch! I've updated the file with a new commit. |
Improved sentence structure for English speakers.
Codecov Report
@@ Coverage Diff @@
## master #15856 +/- ##
==========================================
- Coverage 90.98% 90.97% -0.02%
==========================================
Files 143 145 +2
Lines 49443 49483 +40
==========================================
+ Hits 44985 45015 +30
- Misses 4458 4468 +10
Continue to review full report at Codecov.
|
seems reasonable, thanks. |
For GH users who strictly or heavily use the web-view instead of a local Git, having a direct link is handy, as it does not require downloading the PDF if the user wanted to go to the source of it directly. It's an alternative that allows those interested in more uploads similar to this PDF from the same author(s).