Skip to content

ENH: Citing source in README file #15856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2017
Merged

Conversation

the-nose-knows
Copy link
Contributor

For GH users who strictly or heavily use the web-view instead of a local Git, having a direct link is handy, as it does not require downloading the PDF if the user wanted to go to the source of it directly. It's an alternative that allows those interested in more uploads similar to this PDF from the same author(s).

  • closes: N/A
  • tests added / passed: N/A
  • whatsnew: Added source of PDF to README file for the cheatsheet

For GH users who strictly or heavily use the web-view instead of a local Git, having a direct link is handy, as it does not require downloading the PDF _if_ the user wanted to go to the source of it directly. It's an alternative that allows those interested in more uploads similar to this PDF from the same author(s).
@the-nose-knows the-nose-knows changed the title Citing source in README file ENH: Citing source in README file Mar 31, 2017
@jorisvandenbossche
Copy link
Member

You linked to the R cheatsheet (on which the pandas one is based). Was that on purpose?

@jreback jreback added the Docs label Apr 3, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 3, 2017
@jreback
Copy link
Contributor

jreback commented Apr 3, 2017

actually I think this is reasonable, though I think the wording should be that this is referenced/based on the dplyr sheet.

I re-read the PDF and made sure the wording reflected the content presented. I also changed the source-citing so that is more friendly for .TXT files instead of Markdown or unspecified.
@the-nose-knows
Copy link
Contributor Author

@jorisvandenbossche Good catch! I've updated the file with a new commit.
@jreback feel free to word this to whatever is most appropriate. As long as the spirit of the PR is satisfied, I'm happy with whatever implementation is used.

Improved sentence structure for English speakers.
@codecov
Copy link

codecov bot commented Apr 4, 2017

Codecov Report

Merging #15856 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15856      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.02%     
==========================================
  Files         143      145       +2     
  Lines       49443    49483      +40     
==========================================
+ Hits        44985    45015      +30     
- Misses       4458     4468      +10
Flag Coverage Δ
#multiple 88.73% <ø> (ø) ⬆️
#single 40.63% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/clipboard/windows.py 11.62% <0%> (-1.02%) ⬇️
pandas/io/common.py 69.33% <0%> (-0.93%) ⬇️
pandas/core/common.py 91.03% <0%> (-0.27%) ⬇️
pandas/computation/engines.py 88.88% <0%> (-0.18%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️
pandas/util/clipboard/clipboards.py 26.58% <0%> (ø) ⬆️
pandas/io/feather_format.py 86.66% <0%> (ø) ⬆️
pandas/_version.py 44.65% <0%> (ø) ⬆️
pandas/__init__.py 92.68% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b53d88...735fd94. Read the comment docs.

@jreback jreback merged commit ca8ef49 into pandas-dev:master Apr 4, 2017
@jreback
Copy link
Contributor

jreback commented Apr 4, 2017

seems reasonable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants