Skip to content

DOC: remove older whatsnew #15809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 26, 2017

No description provided.

@jreback jreback added the Docs label Mar 26, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 26, 2017

@jorisvandenbossche what do you think? should remove 0.17 as well? 0.18? (e.g. keep last 2 major releases).

Idea is that this will make docs a bit shorter / build faster (slightly). not sure if its is worth though.

@codecov
Copy link

codecov bot commented Mar 26, 2017

Codecov Report

Merging #15809 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15809      +/-   ##
==========================================
- Coverage      91%   90.99%   -0.02%     
==========================================
  Files         143      143              
  Lines       49384    49384              
==========================================
- Hits        44944    44936       -8     
- Misses       4440     4448       +8
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️
pandas/io/parsers.py 95.51% <0%> (ø) ⬆️
pandas/core/common.py 91.3% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ac0b7...57510d3. Read the comment docs.

@jorisvandenbossche
Copy link
Member

I personally would not remove them. I am more in favor of #6856 -> converting examples to static code-blocks (keeping behaviour as when released, instead of updating examples), which also makes it a lot faster to build.

Although I am maybe a bit too 'attached' to the older whatsnew docs (I regularly search through them, but maybe this is rather uncommon behaviour as I am a dev).

@jreback
Copy link
Contributor Author

jreback commented Mar 27, 2017

@jorisvandenbossche ahh I c, didn't even know that issue existed! ok that actually makes sense. I tagged that a bit. closing then.

@jreback jreback closed this Mar 27, 2017
@jorisvandenbossche
Copy link
Member

Something else we should do, is starting a separate page at a certain point, instead of one huge (or moving the older to a separate page, but problem with that is that it breaks links)

@jreback
Copy link
Contributor Author

jreback commented Mar 27, 2017

@jorisvandenbossche yep, though I think we have a reorg on the whole doc structure somewhere....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants