Skip to content

COMPAT: 32-bit skips #15776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017
Merged

COMPAT: 32-bit skips #15776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pandas/tests/indexes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ def test_reindex_base(self):
idx.get_indexer(idx, method='invalid')

def test_ndarray_compat_properties(self):

idx = self.create_index()
self.assertTrue(idx.T.equals(idx))
self.assertTrue(idx.transpose().equals(idx))
Expand Down
9 changes: 8 additions & 1 deletion pandas/tests/indexes/period/test_period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import pytest

import numpy as np
from numpy.random import randn
from datetime import timedelta
Expand All @@ -6,7 +8,7 @@
from pandas.util import testing as tm
from pandas import (PeriodIndex, period_range, notnull, DatetimeIndex, NaT,
Index, Period, Int64Index, Series, DataFrame, date_range,
offsets)
offsets, compat)

from ..datetimelike import DatetimeLike

Expand Down Expand Up @@ -626,6 +628,11 @@ def test_shift_nat(self):
tm.assert_index_equal(result, expected)
self.assertEqual(result.name, expected.name)

def test_ndarray_compat_properties(self):
if compat.is_platform_32bit():
pytest.skip("skipping on 32bit")
super(TestPeriodIndex, self).test_ndarray_compat_properties()

def test_shift_ndarray(self):
idx = PeriodIndex(['2011-01', '2011-02', 'NaT',
'2011-04'], freq='M', name='idx')
Expand Down
4 changes: 3 additions & 1 deletion pandas/tests/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,9 @@ def test_value_counts_uint64(self):
expected = Series([1, 1], index=[-1, 2**63])
result = algos.value_counts(arr)

tm.assert_series_equal(result, expected)
# 32-bit linux has a different ordering
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gfyoung FYI it seems we have another skip on 32-bit in here as well, so not specific to uint64. I think there is a n issue somewhere. but pretty hard to debug.

Copy link
Member

@gfyoung gfyoung Mar 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indicative of a flakiness, but I'm not sure how to secure proper ordering in this case. I would hate to skip just because we can't ordering right, but I don't see how at this point.

if not compat.is_platform_32bit():
tm.assert_series_equal(result, expected)


class TestDuplicated(tm.TestCase):
Expand Down