Skip to content

CLN: relocate lib.ismember* to hashtable space #15773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 21, 2017

  • fixes .isin on 32-bit (hopefully)
  • perf about 30% better (but this is a small number anyhow) & releases GIL
  • more generic framework

@jreback jreback added the Clean label Mar 21, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 21, 2017
@codecov
Copy link

codecov bot commented Mar 21, 2017

Codecov Report

Merging #15773 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15773      +/-   ##
==========================================
- Coverage   91.01%      91%   -0.02%     
==========================================
  Files         143      143              
  Lines       49377    49403      +26     
==========================================
+ Hits        44941    44957      +16     
- Misses       4436     4446      +10
Impacted Files Coverage Δ
pandas/core/frame.py 97.86% <ø> (-0.1%) ⬇️
pandas/indexes/multi.py 96.59% <100%> (ø) ⬆️
pandas/indexes/numeric.py 97.1% <100%> (-0.02%) ⬇️
pandas/io/parsers.py 95.51% <100%> (ø) ⬆️
pandas/tseries/tools.py 84.93% <100%> (+0.04%) ⬆️
pandas/core/algorithms.py 94.41% <100%> (+0.15%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/io/stata.py 93.47% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163d18e...a7dfe51. Read the comment docs.

@jreback jreback closed this in 32dd929 Mar 21, 2017
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
- fixes .isin on 32-bit (hopefully)
- perf about 30% better
- releases GIL

Author: Jeff Reback <[email protected]>

Closes pandas-dev#15773 from jreback/ismember and squashes the following commits:

a7dfe51 [Jeff Reback] CLN: relocate lib.ismember* to hashtable space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant