BUG: Enforce correct encoding in stata #15768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
changed the title
Ensure StataReader and StataWriter have the correct encoding. Standardized default encoding to 'latin-1' closes pandas-dev#15723
bashtage
force-pushed
the
limit-stata-encoding
branch
from
f549481 to
2f02697
Compare
|
@bashtage side issue. We finally have 32-bit daily wheels. https://travis-ci.org/MacPython/pandas-wheels/jobs/213101390 so this one came up in testing (I am working fixing the rest). Unfort no easy way to test this as has to be on master. But if you have a fix can merge. |
jreback
added
IO Stata
jreback
approved these changes
Mar 21, 2017
pandas/io/stata.py
Outdated
| def __init__(self, encoding='latin-1'): | ||
|
|
||
| if encoding not in VALID_ENCODINGS: | ||
| raise ValueError('Unknown encoding. Only latin-1 and ascii ' |
pandas/tests/io/test_stata.py
Outdated
| @@ -1276,3 +1276,9 @@ def test_out_of_range_float(self): | |||
| original.to_stata(path) | |||
| tm.assertTrue('ColumnTooBig' in cm.exception) | |||
| tm.assertTrue('infinity' in cm.exception) | |||
|
|
|||
| def test_invalid_encoding(self): | |||
| original = self.read_csv(self.csv3) | |||
There was a problem hiding this comment.
can you add the commit number as a comment
|
@jreback I rolled a fix for the 32bit issue into this PR. I can separate if you prefer. |
|
@bashtage totally fine here. thanks! ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #15768 +/- ##
==========================================
- Coverage 91.01% 90.99% -0.02%
==========================================
Files 143 143
Lines 49377 49384 +7
==========================================
- Hits 44941 44938 -3
- Misses 4436 4446 +10
Continue to review full report at Codecov.
|
Fix use of 64-bit integers as keys in general string objects (GSO) by wrapping in strings when used as dictionary keys
bashtage
force-pushed
the
limit-stata-encoding
branch
from
a79a515 to
8278be7
Compare
|
thanks! always a pleasure @bashtage |
|
@bashtage looks like this fixed the 32-bit error as well! https://travis-ci.org/MacPython/pandas-wheels/jobs/213622884 thanks (of course other errors which I am working on ......) |
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Ensure StataReader and StataWriter have the correct encoding. Standardized default encoding to 'latin-1' closes pandas-dev#15723 Author: Kevin Sheppard <[email protected]> Closes pandas-dev#15768 from bashtage/limit-stata-encoding and squashes the following commits: 8278be7 [Kevin Sheppard] BUG: Fix limited key range on 32-bit platofrms 2f02697 [Kevin Sheppard] BUG: Enforce correct encoding in stata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure StataReader and StataWriter have the correct encoding.
Standardized default encoding to 'latin-1'
closes #15723
git diff upstream/master | flake8 --diff