Skip to content

BUG: replace coerces incorrect dtype #15742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 20, 2017

closes #12747

Author: sinhrks [email protected]

This patch had conflicts when merged, resolved by
Committer: Jeff Reback [email protected]

closes #15742
Closes #12780 from sinhrks/replace_type and squashes the following commits:

f9154e8 [sinhrks] remove unnecessary comments
279fdf6 [sinhrks] remove import failure
de44877 [sinhrks] BUG: replace coerces incorrect dtype

closes pandas-dev#12747

Author: sinhrks <[email protected]>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <[email protected]>

Closes pandas-dev#12780 from sinhrks/replace_type and squashes the following commits:

f9154e8 [sinhrks] remove unnecessary comments
279fdf6 [sinhrks] remove import failure
de44877 [sinhrks] BUG: replace coerces incorrect dtype
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Bug labels Mar 20, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 20, 2017
@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #15742 into master will decrease coverage by <.01%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master   #15742      +/-   ##
==========================================
- Coverage   91.01%   91.01%   -0.01%     
==========================================
  Files         143      143              
  Lines       49380    49401      +21     
==========================================
+ Hits        44943    44961      +18     
- Misses       4437     4440       +3
Impacted Files Coverage Δ
pandas/core/internals.py 93.62% <100%> (+0.02%) ⬆️
pandas/types/cast.py 85.11% <80%> (-0.35%) ⬇️
pandas/tseries/index.py 95.29% <0%> (-0.1%) ⬇️
pandas/core/common.py 91.3% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e29db...8bde21a. Read the comment docs.

@jreback jreback merged commit 8bde21a into pandas-dev:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/API: Fix .replace dtype conversion rules
2 participants