Skip to content

TST: Reorganize package_check and skip_if_no_package #15709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2017
Merged

TST: Reorganize package_check and skip_if_no_package #15709

merged 1 commit into from
Mar 17, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 17, 2017 •
edited
Loading

skip_if_no_package literally just calls package_check with no additional decorations and with confusing *args and **kwargs. However, skip_if_no_package is a better name than package_check.

@gfyoung
TST: Replace check_package with skip_if_no_package
c628018 
check_package literally just called skip_if_no_package
with no additional decorations.
jreback
jreback approved these changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is some old code

thxs

@codecov
Copy link

codecov bot commented Mar 17, 2017

Codecov Report

Merging #15709 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15709      +/-   ##
==========================================
- Coverage   91.03%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49411    49409       -2     
==========================================
- Hits        44979    44967      -12     
- Misses       4432     4442      +10
Impacted Files Coverage Δ
pandas/util/testing.py 80.81% <100%> (-0.04%) ❌
pandas/io/gbq.py 25% <0%> (-58.34%) ❌
pandas/tools/merge.py 93.68% <0%> (-0.34%) ❌
pandas/core/frame.py 97.87% <0%> (-0.1%) ❌
pandas/core/common.py 91.3% <0%> (+0.33%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f6f63...c628018. Read the comment docs.

@gfyoung gfyoung changed the title TST: Replace check_package with skip_if_no_package TST: Reorganize package_check and skip_if_no_package Mar 17, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 17, 2017
@jreback jreback added the Testing pandas testing functions or related to the test suite label Mar 17, 2017
@jreback jreback merged commit 087c2f1 into pandas-dev:master Mar 17, 2017
@jreback
Copy link
Contributor

jreback commented Mar 17, 2017

thanks!

@gfyoung gfyoung deleted the skip-package-refactor branch March 17, 2017 13:11
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@gfyoung @AnkurDedania
TST: Replace check_package with skip_if_no_package (pandas-dev#15709)
50bbb09 
check_package literally just called skip_if_no_package
with no additional decorations.
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
@gfyoung @mattip
TST: Replace check_package with skip_if_no_package (pandas-dev#15709)
77402ff 
check_package literally just called skip_if_no_package
with no additional decorations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyoung @jreback