Skip to content

MAINT: test with manylinux numpy/scipy pre-release #15702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

matthew-brett
Copy link
Contributor

Numpy / Scipy switching to daily manylinux wheels of trunk, instead of building
wheels specific to Ubuntu 12.04 for every commit. Use these new wheels
for numpy and scipy pre-release testing.

See: #15699, #15689 and scipy/scipy#7188.

Numpy switching to daily manylinux wheels of trunk, instead of building
wheels specific to Ubuntu 12.04 for every commit.  Use these new wheels
for numpy pre-release testing.
@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

oh this is nice. thanks @matthew-brett

@jreback jreback added the CI Continuous Integration label Mar 16, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 16, 2017
@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

maybe have the old URL re-direct?

@matthew-brett
Copy link
Contributor Author

My first-pass plan was to find everyone who is using the old URL and update their configs to use the new ones - but it's not a bad idea to redirect....

@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

and that URL is very odd......

@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

@matthew-brett side questions.

  • I would not be averse to doing similar wheels for pandas. how are you doing this now? (I assume using travis / circle ci cron?)
  • do you know if anyone is building nightly conda packages? (and putting them somewhere)?

@jreback jreback merged commit 3cac2d5 into pandas-dev:master Mar 16, 2017
@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

thanks @matthew-brett

@matthew-brett
Copy link
Contributor Author

Daily wheels would be excellent! Yes, it's a travis cron job building on the daily branch of MacPython/numpy-wheels :

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #15702 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15702      +/-   ##
==========================================
- Coverage   91.03%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49410    49410              
==========================================
- Hits        44978    44967      -11     
- Misses       4432     4443      +11
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 93.68% <0%> (-0.34%)
pandas/core/frame.py 97.87% <0%> (-0.1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe15466...62a9fd1. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

so what needs to change here? https://github.com/MacPython/pandas-wheels

@matthew-brett
Copy link
Contributor Author

Have a look at : https://github.com/MacPython/numpy-wheels/blob/master/.travis.yml . Note DAILY_COMMIT. In the daily branch we have - DAILY_COMMIT=master. Then it's just a question of setting up the cron job via the travis-ci interface : https://docs.travis-ci.com/user/cron-jobs/

@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

ok we shall c. in theory it should work.

@jreback
Copy link
Contributor

jreback commented Mar 16, 2017

@matthew-brett how does DAILY_COMMIT get defined? (IOW by the cron on travis?)

@matthew-brett
Copy link
Contributor Author

No, I defined DAILY_COMMIT in the daily branch, but another option would be to detect the cron job using something like:

if [ "$TRAVIS_EVENT_TYPE" == "cron" ]; then DAILY_COMMIT=master; fi

or similar.

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Numpy switching to daily manylinux wheels of trunk, instead of building
wheels specific to Ubuntu 12.04 for every commit.  Use these new wheels
for numpy pre-release testing.
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
Numpy switching to daily manylinux wheels of trunk, instead of building
wheels specific to Ubuntu 12.04 for every commit.  Use these new wheels
for numpy pre-release testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants