Skip to content

CLN: push key coercion to the indexes with Index._convert_list_indexer #15678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 13, 2017

CLN: push key coercion to the indexes themselves to simplify a bit

CLN: push key coercion to the indexes themselves to simplify a bit
@jreback jreback added Clean Indexing Related to indexing on series/frames, not to indexes themselves labels Mar 13, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 13, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 13, 2017

makes us a tiny bit more DRY.

@jorisvandenbossche jorisvandenbossche changed the title DOC: use shared docs on Index._convert_list_indexer CLN: push key coercion to the indexes with Index._convert_list_indexer Mar 13, 2017
@codecov-io
Copy link

codecov-io commented Mar 13, 2017

Codecov Report

Merging #15678 into master will decrease coverage by 0.02%.
The diff coverage is 92.1%.

@@            Coverage Diff             @@
##           master   #15678      +/-   ##
==========================================
- Coverage   91.03%   91.01%   -0.03%     
==========================================
  Files         143      143              
  Lines       49380    49386       +6     
==========================================
- Hits        44953    44948       -5     
- Misses       4427     4438      +11
Impacted Files Coverage Δ
pandas/indexes/base.py 96.15% <100%> (+0.01%)
pandas/indexes/numeric.py 97.11% <100%> (+0.01%)
pandas/indexes/category.py 98.28% <85.71%> (-0.31%)
pandas/core/indexing.py 94.08% <88.88%> (-0.13%)
pandas/indexes/multi.py 96.59% <91.66%> (-0.06%)
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 93.61% <0%> (-0.34%)
pandas/core/frame.py 97.87% <0%> (-0.1%)
pandas/util/testing.py 80.85% <0%> (+0.09%)
pandas/core/common.py 91.3% <0%> (+0.33%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32df1e6...a42ae54. Read the comment docs.

@jreback jreback merged commit 05d70f4 into pandas-dev:master Mar 13, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
CLN: push key coercion to the indexes themselves to simplify a bit
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
CLN: push key coercion to the indexes themselves to simplify a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants