Skip to content

DOC: doc warnings #15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

DOC: doc warnings #15647

wants to merge 4 commits into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 10, 2017 •
edited
Loading

No description provided.

@jreback jreback added the Docs label Mar 10, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 10, 2017
jreback
jreback commented Mar 10, 2017
View reviewed changes
doc/source/whatsnew/v0.10.1.txt Outdated
@@ -58,7 +58,8 @@ perform queries on a table, by passing a list to ``data_columns``

# on-disk operations
store.append('df', df, data_columns = ['B','C','string','string2'])
store.select('df',[ 'B > 0', 'string == foo' ])
store.select('df').dtypes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche attempting to see what is going on here......

@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017

don't merge yet.

@codecov-io
Copy link

codecov-io commented Mar 10, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@94c6c0c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15647   +/-   ##
=========================================
  Coverage          ?      91%           
=========================================
  Files             ?      143           
  Lines             ?    49324           
  Branches          ?        0           
=========================================
  Hits              ?    44885           
  Misses            ?     4439           
  Partials          ?        0
Impacted Files Coverage Δ
pandas/core/frame.py 97.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c6c0c...6afb394. Read the comment docs.

@jorisvandenbossche
Copy link
Member

@jreback Fixed the problems with #15620 in that PR, to keep the credit.

@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017

ok thanks

@jreback jreback changed the title DOC: DataFrame.dropna doc-string examples DOC: doc warnings Mar 10, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017

ok I think this fixed the HDFStore issues.

@jorisvandenbossche
Copy link
Member

Cool.
Is the list with with expressions not supported anymore? Or just for some reason failing on travis?

@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017 •
edited
Loading

@jorisvandenbossche no a list is still accepted (but nicer with the and). The issue was the bare strings, e.g. bar=foo; for some reason the foo is interpreted as an ascii string I think, you need to use the correct quotes ". I cannot repro this so maybe its an encoding issue (IOW even though we are building with 3.5, maybe the encoding of the file itself is ascii, just guessing here).

I put a note on the original issue #15544 to see if @chris-b1 has any ideas.

@jreback jreback closed this in 67d529a Mar 10, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017

@jorisvandenbossche ok this fixes a bunch of warnings (still a couple remaining) :>

some png links and a LICENSE link........but enough for now.

@jorisvandenbossche
Copy link
Member

The png and license link warnings are already present for a few years, so not too urgent :-)

@chris-b1
Copy link
Contributor

chris-b1 commented Mar 10, 2017 •
edited
Loading

The issue here was that foo was a defined name in a different whatsnew section

foo = pd.Series([1,2], name='foo')

Now this comparison was unpacking the ints in that Series (which tbh I didn't know we did - but basically is like .isin) and raising the now invalid comparison.

store.select('df',[ 'B > 0', 'string == foo' ])

In past doc versions, this was just returning an empty result (here). This is exactly that type of invalid comparisons we were trying to catch with #15544, so I think it's good that this raised!

@jreback
Copy link
Contributor Author

jreback commented Mar 10, 2017

@chris-b1 ahh that makes sense then. thanks for the look!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@jreback @AnkurDedania
DOC: doc warnings
c1065da 
Author: Jeff Reback <[email protected]>

Closes pandas-dev#15647 from jreback/doc and squashes the following commits:

6afb394 [Jeff Reback] gbq install adjustment
0fd4499 [Jeff Reback] maybe
d5ec228 [Jeff Reback] DOC: fixup some doc-links
b7ea898 [Jeff Reback] DOC: some deprecation warnings removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jreback @codecov-io @jorisvandenbossche @chris-b1