Skip to content

BUG: Incorrect value updating for groupby.cummin/max (#15635) #15642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mroeschke
Copy link
Member

Nice catch @adbull. The original implementation was incorrectly setting the incorrect cummin/max value.

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #15642 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15642      +/-   ##
==========================================
- Coverage   91.02%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49324    49324              
==========================================
- Hits        44898    44886      -12     
- Misses       4426     4438      +12
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 91.76% <0%> (-0.35%)
pandas/core/common.py 90.96% <0%> (-0.34%)
pandas/core/frame.py 97.87% <0%> (-0.1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470c327...b92b81a. Read the comment docs.

@jreback jreback added this to the 0.20.0 milestone Mar 10, 2017
@jreback jreback closed this in 4ce9c0c Mar 10, 2017
@jreback
Copy link
Contributor

jreback commented Mar 10, 2017

thanks!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
closes pandas-dev#15635

Author: Matt Roeschke <[email protected]>

Closes pandas-dev#15642 from mroeschke/fix_15635 and squashes the following commits:

b92b81a [Matt Roeschke] BUG: Incorrect value updating for groupby.cummin/max (pandas-dev#15635)
@mroeschke mroeschke deleted the fix_15635 branch December 20, 2017 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cython groupby cummin/cummax assumes groups ordered
3 participants