Skip to content

DOC: use mathjax on sphinx - #15469 Exponentially Weighed Windows pages now shows formulas #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2017

Conversation

cdemulde
Copy link
Contributor

@cdemulde cdemulde commented Mar 8, 2017

closes #15469

@jreback jreback added the Docs label Mar 8, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 8, 2017
@@ -46,8 +46,9 @@
'ipython_sphinxext.ipython_console_highlighting',
'sphinx.ext.intersphinx',
'sphinx.ext.coverage',
'sphinx.ext.pngmath',
'sphinx.ext.ifconfig',
#'sphinx.ext.pngmath',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see pngmath was deprecated. Is this needed for anything else though? can you build locally and give a check? (you can just ping here if ok)

@cdemulde cdemulde force-pushed the documentation_update branch from a7ebc4d to eee5f98 Compare March 8, 2017 18:45
@jorisvandenbossche
Copy link
Member

So indeed pngmath is deprecated. We have to choose between sphinx.ext.imgmath or sphinx.ext.mathjax as described below. I would personally go with mathjax (you don't need latex install for building the docs, but it renders only if you are online, but for html docs I think this is OK)

http://www.sphinx-doc.org/en/stable/ext/math.html

@@ -46,8 +46,8 @@
'ipython_sphinxext.ipython_console_highlighting',
'sphinx.ext.intersphinx',
'sphinx.ext.coverage',
'sphinx.ext.pngmath',
'sphinx.ext.ifconfig',
'sphinx.ext.mathjax',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well have to remove the whitespace on merge

@jreback
Copy link
Contributor

jreback commented Mar 8, 2017

lgtm (minor comment)

@jorisvandenbossche jorisvandenbossche changed the title fix issue #15469 Exponentially Weighed Windows pages now shows formulas DOC: use mathjax on sphinx - #15469 Exponentially Weighed Windows pages now shows formulas Mar 8, 2017
@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #15618 into master will decrease coverage by -0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15618      +/-   ##
==========================================
- Coverage   91.02%   90.99%   -0.03%     
==========================================
  Files         143      143              
  Lines       49301    49301              
==========================================
- Hits        44875    44863      -12     
- Misses       4426     4438      +12
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 91.76% <0%> (-0.35%)
pandas/core/common.py 90.96% <0%> (-0.34%)
pandas/core/frame.py 97.87% <0%> (-0.1%)
pandas/core/generic.py 96.25% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d69988...f4684fb. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 9, 2017

@jorisvandenbossche ok on merging this?

@jorisvandenbossche
Copy link
Member

Yep. Fixed the whitespace before merging.

@cdemulde Thanks!
(btw, you should set your editor settings to not introduce tabs, but 4 spaces instead of tab)

@jreback
Copy link
Contributor

jreback commented Mar 9, 2017

https://travis-ci.org/pandas-dev/pandas/jobs/209368323

I restarted this twice and failed at the same point :<

@jorisvandenbossche
Copy link
Member

The problem with the parallel building is that it just says "waiting for workers" instead of giving output, so difficult to see what is going on. In any case, this worked locally. Will try with more verbose output.

@jreback
Copy link
Contributor

jreback commented Mar 9, 2017

maybe add -v for now? and certainly take out -j 2 as not helping :<

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Exponentially Weighted Windows page not showing formulas
4 participants