-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: use mathjax on sphinx - #15469 Exponentially Weighed Windows pages now shows formulas #15618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: use mathjax on sphinx - #15469 Exponentially Weighed Windows pages now shows formulas #15618
Conversation
doc/source/conf.py
Outdated
@@ -46,8 +46,9 @@ | |||
'ipython_sphinxext.ipython_console_highlighting', | |||
'sphinx.ext.intersphinx', | |||
'sphinx.ext.coverage', | |||
'sphinx.ext.pngmath', | |||
'sphinx.ext.ifconfig', | |||
#'sphinx.ext.pngmath', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see pngmath
was deprecated. Is this needed for anything else though? can you build locally and give a check? (you can just ping here if ok)
a7ebc4d
to
eee5f98
Compare
So indeed pngmath is deprecated. We have to choose between |
doc/source/conf.py
Outdated
@@ -46,8 +46,8 @@ | |||
'ipython_sphinxext.ipython_console_highlighting', | |||
'sphinx.ext.intersphinx', | |||
'sphinx.ext.coverage', | |||
'sphinx.ext.pngmath', | |||
'sphinx.ext.ifconfig', | |||
'sphinx.ext.mathjax', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well have to remove the whitespace on merge
lgtm (minor comment) |
Codecov Report
@@ Coverage Diff @@
## master #15618 +/- ##
==========================================
- Coverage 91.02% 90.99% -0.03%
==========================================
Files 143 143
Lines 49301 49301
==========================================
- Hits 44875 44863 -12
- Misses 4426 4438 +12
Continue to review full report at Codecov.
|
@jorisvandenbossche ok on merging this? |
Yep. Fixed the whitespace before merging. @cdemulde Thanks! |
https://travis-ci.org/pandas-dev/pandas/jobs/209368323 I restarted this twice and failed at the same point :< |
The problem with the parallel building is that it just says "waiting for workers" instead of giving output, so difficult to see what is going on. In any case, this worked locally. Will try with more verbose output. |
maybe add |
…indows pages now shows formulas (pandas-dev#15618)
closes #15469