Revert FrozenList changes (doc build slowdown, #15559)

[jorisvandenbossche]

See #15559. This temporarily reverts #15506, to see if this fixes the doc build slowdown.

[jorisvandenbossche]

So I am totally puzzled about why, but reverting this does fix the doc build timeout, see https://travis-ci.org/pandas-dev/pandas/builds/207655451

While we figure this out, I would like to merge this revert for now, because with current master it makes doc building really unbearable (certainly with the docathon coming up).

[jreback]

sure pls create an issue (or leave this one open and i'll take a look)

where was the doc build hanging (what part)?

[codecov-io]

Codecov Report

Merging #15566 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15566      +/-   ##
==========================================
- Coverage   91.07%   91.04%   -0.03%     
==========================================
  Files         136      136              
  Lines       49167    49155      -12     
==========================================
- Hits        44777    44754      -23     
- Misses       4390     4401      +11

Impacted Files	Coverage Δ
pandas/core/strings.py	98.48% <ø> (ø)	✅
pandas/core/panel.py	97.22% <100%> (ø)	✅
pandas/core/reshape.py	99.25% <100%> (ø)	✅
pandas/indexes/frozen.py	93.54% <100%> (+0.3%)	✅
pandas/tools/concat.py	97.62% <100%> (ø)	✅
pandas/io/gbq.py	25% <0%> (-58.34%)	❌
pandas/tools/merge.py	91.78% <0%> (-0.35%)	❌
pandas/util/testing.py	81.87% <0%> (-0.19%)	❌
pandas/core/frame.py	97.83% <0%> (-0.1%)	❌
pandas/indexes/base.py	96.22% <0%> (+0.05%)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae4fd1...befd858. Read the comment docs.

[jorisvandenbossche]

The full 'reading' part (that is AFAIK the part where the ipython code blocks are executed). I am thinking of how we can try to profile that.

[jreback]

using this to debug (it prints a LOT)
-vvv is verbose, -N removes the color output, and removed the -P to try

diff --git a/doc/make.py b/doc/make.py
index 8a6d4e5..3c47409 100755
--- a/doc/make.py
+++ b/doc/make.py
@@ -197,7 +197,7 @@ def html():
                 print(e)
                 print("Failed to convert %s" % nb)
 
-    if os.system('sphinx-build -P -b html -d build/doctrees '
+    if os.system('sphinx-build -vvv -b html -d build/doctrees '
                  'source build/html'):
         raise SystemExit("Building HTML failed.")

we should prob always add -v just to have it print out files as it reads them.

still not sure why it fails

[jreback]

so going to merge this and we can figure out later.