Skip to content

BUG: handle empty lists in json_normalize #15535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented Mar 1, 2017

@rgbkrk
Copy link
Contributor Author

rgbkrk commented Mar 1, 2017

I'll come back to this for the other checkboxes.

@jreback jreback added the IO JSON read_json, to_json, json_normalize label Mar 1, 2017
@jreback
Copy link
Contributor

jreback commented Mar 1, 2017

you'll want to rebase on master as travis was having some issues

@rgbkrk rgbkrk force-pushed the empty-data-on-normalize branch from ed17712 to 3c3cb8a Compare March 1, 2017 21:06
@codecov-io
Copy link

codecov-io commented Mar 3, 2017

Codecov Report

Merging #15535 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15535      +/-   ##
==========================================
- Coverage   91.07%   91.04%   -0.03%     
==========================================
  Files         136      136              
  Lines       49165    49167       +2     
==========================================
- Hits        44775    44764      -11     
- Misses       4390     4403      +13
Impacted Files Coverage Δ
pandas/io/json/normalize.py 97.91% <100%> (+0.04%)
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 91.78% <0%> (-0.35%)
pandas/util/testing.py 81.87% <0%> (-0.19%)
pandas/core/frame.py 97.83% <0%> (-0.1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e1168...62138d0. Read the comment docs.

@rgbkrk rgbkrk force-pushed the empty-data-on-normalize branch from 3c3cb8a to d2fbe44 Compare March 4, 2017 07:55
@rgbkrk rgbkrk force-pushed the empty-data-on-normalize branch from d2fbe44 to 62138d0 Compare March 4, 2017 08:00
@rgbkrk
Copy link
Contributor Author

rgbkrk commented Mar 4, 2017

Added a test and appended to the whatsnew. Test passes locally for me, time to wait on CI.

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Mar 4, 2017
@jorisvandenbossche jorisvandenbossche merged commit 7ae4fd1 into pandas-dev:master Mar 4, 2017
@jorisvandenbossche
Copy link
Member

@rgbkrk Thanks!

@rgbkrk rgbkrk deleted the empty-data-on-normalize branch March 4, 2017 16:01
@rgbkrk
Copy link
Contributor Author

rgbkrk commented Mar 4, 2017

No problem, thank you!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_normalize should be able to accept an empty list
4 participants