Skip to content

DOC: Update contributing for test_fast, fix doc Windows build #15523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2017

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Feb 27, 2017

  • Add test_fast.bat for Windows developers.
  • Update contributing.rst to refer to pytest-xdist and reference fast testing scripts
  • Update contributing.rst to delete references to pep8radius
  • Fix doc\make.py to not spit out error message about rm on Windows by using os.remove()

No code changes!


test_fast.bat

This can significantly reduce the time it takes to locally run tests before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add that you will need to pip install pytest-xdist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback OK, just pushed that commit. You probably can kill some of the travis/circleCI/appveyor stuff since there is no code to test here.

Maybe one day pytest-xdist will be available via a standard conda install!

@jreback
Copy link
Contributor

jreback commented Feb 27, 2017

minor comment, otherwise lgtm.

@jreback jreback added Build Library building on various platforms Docs labels Feb 27, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 27, 2017
@jreback
Copy link
Contributor

jreback commented Feb 27, 2017

thanks @Dr-Irv yeah I killed the appveyor/travis jobs (circleci does auto-killing itself :)

@jreback
Copy link
Contributor

jreback commented Feb 27, 2017

@jorisvandenbossche ?

@jorisvandenbossche jorisvandenbossche merged commit e0647ba into pandas-dev:master Feb 27, 2017
@jorisvandenbossche
Copy link
Member

@Dr-Irv Thanks!

@Dr-Irv Dr-Irv deleted the DocFix branch February 28, 2017 15:43
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
…-dev#15523)

* DOC: Update contributing for test_fast, fix doc Windows build

* add pip install for xdist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants