Skip to content

BUG: pivot_table over Categorical Columns #15511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

BUG: pivot_table over Categorical Columns #15511

wants to merge 4 commits into from

Conversation

verhalenn
Copy link

@codecov-io
Copy link

codecov-io commented Feb 26, 2017 •
edited
Loading

Codecov Report

Merging #15511 into master will increase coverage by 0.71%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15511      +/-   ##
==========================================
+ Coverage   90.36%   91.08%   +0.71%     
==========================================
  Files         136      136              
  Lines       49553    49101     -452     
==========================================
- Hits        44780    44724      -56     
+ Misses       4773     4377     -396
Impacted Files Coverage Δ
pandas/tools/pivot.py 95.07% <100%> (+0.03%) ✅
pandas/util/decorators.py 67.32% <0%> (-1.28%) ❌
pandas/core/frame.py 97.73% <0%> (-0.1%) ❌
pandas/util/testing.py 82.06% <0%> (-0.04%) ❌
pandas/core/generic.py 96.31% <0%> (ø) ✅
pandas/util/print_versions.py 15.71% <0%> (ø) ✅
pandas/core/groupby.py 95% <0%> (+0.01%) ✅
pandas/types/cast.py 85.65% <0%> (+0.23%) ✅
pandas/core/common.py 91.36% <0%> (+0.33%) ✅
pandas/io/gbq.py 40% <0%> (+23.53%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ae4c7...bf0fdeb. Read the comment docs.

@jreback jreback changed the title Issue15193 pivot_table over Categorical Columns Feb 26, 2017
@jreback jreback changed the title pivot_table over Categorical Columns BUG: pivot_table over Categorical Columns Feb 26, 2017
@jreback jreback added Bug Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Feb 26, 2017
jreback
jreback reviewed Feb 26, 2017
View reviewed changes
pandas/tools/pivot.py Outdated
@@ -175,6 +175,10 @@ def pivot_table(data, values=None, index=None, columns=None, aggfunc='mean',
if len(index) == 0 and len(columns) > 0:
table = table.T

# GH 15193
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a 1-liner explaining what is going on here

@jreback
Copy link
Contributor

jreback commented Feb 27, 2017

lgtm. ping on green (a couple of typos, but will fix on merge).

@jreback jreback added this to the 0.20.0 milestone Feb 27, 2017
@jreback jreback closed this in ed2a2e4 Mar 4, 2017
@jreback
Copy link
Contributor

jreback commented Mar 4, 2017

thanks!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@AnkurDedania
BUG: pivot_table over Categorical Columns
ef9a93a 
closes pandas-dev#15193

Author: Nicholas Ver Halen <[email protected]>

Closes pandas-dev#15511 from verhalenn/issue15193 and squashes the following commits:

bf0fdeb [Nicholas Ver Halen] Added description to code change.
adf8616 [Nicholas Ver Halen] Added whatsnew for issue 15193
a643267 [Nicholas Ver Halen] Added test for issue 15193
d605251 [Nicholas Ver Halen] Made sure pivot_table propped na columns
@TomAugspurger TomAugspurger mentioned this pull request May 16, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

pivot_table over Categorical columns
3 participants
@verhalenn @codecov-io @jreback