Skip to content

DOC: fix doc build warnings #15505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

jorisvandenbossche
Copy link
Member

Bunch of small fixes that caused warnings/errors

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Feb 25, 2017
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

as an aside not averse to having the doc build fail on (certain types of warnings)

e.g. PR adds docs which then cause more warnings

not sure how hard this would actually be though (maybe sphinx can do it?)

@jorisvandenbossche
Copy link
Member Author

Yes, I know (and think there is an issue about that somewhere). The problem is that the current doc build is not yet fully warning-free (also not after this PR), of which some I don't directly know how to fix. So as long that is not the case, we cannot let it fail on that.

@jorisvandenbossche
Copy link
Member Author

We could let sphinx fail on a a warning/error, or otherwise parse the log and if certain words are present (like 'ERROR') then let travis fail (and in this way, be a bit more flexible on what is not allowed to fail).

@codecov-io
Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #15505 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15505      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         136      136              
  Lines       49553    49553              
==========================================
- Hits        44781    44780       -1     
- Misses       4772     4773       +1
Impacted Files Coverage Δ
pandas/io/html.py 84.48% <ø> (ø)
pandas/io/parsers.py 95.51% <ø> (ø)
pandas/io/json/normalize.py 97.87% <ø> (ø)
pandas/core/generic.py 96.31% <ø> (ø)
pandas/core/common.py 91.02% <ø> (-0.34%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80275d...172a85e. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit 303541e into pandas-dev:master Feb 25, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants