Skip to content

CLN: split off frozen (immutable) data structures into pandas/indexes/frozen.py #15477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 22, 2017

should make it a bit easier to work with these; and no reason to be in pandas/core/base.py

@jreback jreback added the Clean label Feb 22, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 22, 2017
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Feb 22, 2017
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (apart from the pickle failures)

# our Unpickler sub-class to override methods and some dispatcher
# functions for compat
base_class = pkl._Unpickler if compat.PY3 else pkl.Unpickler
class Unpickler(base_class):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, object for py2

@codecov-io
Copy link

codecov-io commented Feb 23, 2017

Codecov Report

Merging #15477 into master will increase coverage by <.01%.
The diff coverage is 86.07%.

@@            Coverage Diff             @@
##           master   #15477      +/-   ##
==========================================
+ Coverage   90.36%   90.36%   +<.01%     
==========================================
  Files         135      136       +1     
  Lines       49519    49532      +13     
==========================================
+ Hits        44747    44759      +12     
- Misses       4772     4773       +1
Impacted Files Coverage Δ
pandas/core/base.py 95.51% <ø> (+0.35%)
pandas/indexes/multi.py 96.65% <100%> (ø)
pandas/indexes/base.py 96.22% <100%> (-0.02%)
pandas/compat/pickle_compat.py 68.29% <41.66%> (+4.4%)
pandas/indexes/frozen.py 93.54% <93.54%> (ø)
pandas/core/common.py 91.02% <ø> (-0.34%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94186d...2a64a4f. Read the comment docs.

@jreback jreback closed this in 81c57e2 Feb 24, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
…/frozen.py

should make it a bit easier to work with these; and no reason to be in
pandas/core/base.py

Author: Jeff Reback <[email protected]>

Closes pandas-dev#15477 from jreback/frozen and squashes the following commits:

2a64a4f [Jeff Reback] CLN: split off frozen (immutable) data structures into pandas/indexes/frozen.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants