GH6322, Bug on reset_index for a MultiIndex of all NaNs #15466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reset_index function fails for a MultiIndex if at least one column of the index is all NaN.
jreback
added
Bug
Missing-data
|
thanks @tzinckgraf (you had a couple of flake issues, but I fixed on merge) |
|
@jreback thank you. I ran |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#6322 Author: tzinckgraf <[email protected]> Closes pandas-dev#15466 from tzinckgraf/GH6322 and squashes the following commits: 35f97f4 [tzinckgraf] GH6322, Bug on reset_index for a MultiIndex of all NaNs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reset_index function fails for a MultiIndex if at
least one column of the index is all NaN.
git diff upstream/master | flake8 --diffAs per the comment in the issue, I tried other solutions such as putting the
takeunder anif len(values)call, unfortunately that broke other issues downstream.I started to investigate and it seems like a
MultiIndexmakes a category that ignoresNaN, so thevaluesin thereset_indexis empty. After trying a few options, theif mask.all()seemed like the simplest change.