TST: skip gbq test again / fix parsers/test_network url #15407
Conversation
jreback
added
IO Google
Testing
| @@ -15,42 +15,32 @@ | |||
| from pandas.io.parsers import read_csv, read_table | |||
|
|
|||
|
|
|||
| class TestCompressedUrl(object): | |||
| @pytest.fixture | |||
| def salaries_table(scope='module'): | |||
There was a problem hiding this comment.
scope goes on the decorator, not the function.
There was a problem hiding this comment.
thanks, that was a typo!
There was a problem hiding this comment.
odd linter didn't even catch that
| @@ -17,5 +17,5 @@ def pytest_runtest_setup(item): | |||
| if 'slow' not in item.keywords and item.config.getoption("--only-slow"): | |||
| pytest.skip("skipping due to --only-slow") | |||
|
|
|||
| @pytest.mark.parametrize( | ||
| "compression,extension", [('gzip', '.gz'), ('bz2', '.bz2'), | ||
| ('zip', '.zip'), ('xz', '.xz')]) | ||
| def test_compressed_urls(salaries_table, compression, extension): |
There was a problem hiding this comment.
@TomAugspurger I had to do this in an odd way (meaning having the parameterized fixed call another function)
as the @tm.network decorator doesn't play nice in python 2 ONLY. It works in python 3 though.
any idea?
There was a problem hiding this comment.
IIRC, decorators need to fully copy the whole argument signature. This is not too bad on Python 3.4+ because functools.wraps does it already, but it's a bit of a pain on 2.7. The easiest is to use the decorator package, though on matplotlib, I just replaced the decorators like that with an automatic fixture and some markers.
There was a problem hiding this comment.
@QuLogic thanks for the expl.
yeah I think we need to fix tm.network and just make it a marker.. Though if you have suggestions pls speak up! (or just do a PR!).
There was a problem hiding this comment.
so you just use decorator.decorator instead of functools.wraps?
if its only for testing purposes, then we could easily do that (though even easier would be to fix our tm.network ....)
There was a problem hiding this comment.
The syntax of decorator.decorator is a bit different; it replaces the outer function portion and you only need the wrapper bit, but I didn't pursue it much further.
No description provided.