Skip to content

Numexpr 2.4.6 #15383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Numexpr 2.4.6 #15383

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ab79c54
Require numexpr 2.6.2
Feb 13, 2017
ac62653
Require numexpr 2.4.6
Feb 13, 2017
6e12e29
Added a notice on the recommended numexpr version
Feb 13, 2017
e45b742
Moved pinned versions in CI folder to 2.4.6
Feb 13, 2017
8bd4ed1
numexpr 2.4.6 requirement moved to other enhancements section
Feb 13, 2017
f225598
Updated test_compat for numexpr 2.4.6
Feb 13, 2017
3b6e58b
Removed recomendation for numexpr 2.6.2
Feb 13, 2017
93f54aa
numexpr section moved to Other API changes section
Feb 13, 2017
7a275ce
Fixed a typo
Feb 13, 2017
7575ba2
Using constants instead of literals for numexpr version
Feb 13, 2017
c1aae19
Fixed a lint error
Feb 14, 2017
0d4ab9a
Restored the old numexpr version dependencies to adjust for old requi…
Feb 14, 2017
73f0319
numexpr requisite raised to 2.4.6
Feb 14, 2017
c081199
Relax the exact message for the ImportError
Feb 14, 2017
e1b34a9
Force a reload of pd.computation for actually triggering the UserWarning
Feb 15, 2017
c417fe2
Simplify and remove UserWarning testing on numexpr import
Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ Recommended Dependencies

* `numexpr <https://github.com/pydata/numexpr>`__: for accelerating certain numerical operations.
``numexpr`` uses multiple cores as well as smart chunking and caching to achieve large speedups.
If installed, must be Version 2.1 or higher (excluding a buggy 2.4.4). Version 2.4.6 or higher is highly recommended.
If installed, must be Version 2.4.6 or higher. Numexpr 2.6.2 or higher is strongly recommended.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the recommended part

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, IMO the improvements in https://github.com/pydata/numexpr/blob/master/RELEASE_NOTES.rst#changes-from-261-to-262 are worth a recommendation, but I can remove it if you insist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be but back compat is more important


* `bottleneck <http://berkeleyanalytics.com/bottleneck>`__: for accelerating certain types of ``nan``
evaluations. ``bottleneck`` uses specialized cython routines to achieve large speedups.
Expand Down
6 changes: 5 additions & 1 deletion doc/source/whatsnew/v0.20.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
.. _whatsnew_0200:

v0.20.0 (????, 2016)
v0.20.0 (????, 2017)
--------------------

This is a major release from 0.19 and includes a small number of API changes, several new features,
enhancements, and performance improvements along with a large number of bug fixes. We recommend that all
users upgrade to this version.

.. warning::

Due to important fixes and performance improvements, ``numexpr`` version is now required to be >= 2.4.6 and it will not be used at all if this requisite is not fullfilled (:issue:`15213`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would just move this to the other api changes section; just say 2.4.6 is now required

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably mean "Other enhancements" section (numexpr does not introduce any API change).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an API change for pandas meaning if u has a version that is no longer supported then things will change - its also something to be aware of when upgrading


Highlights include:

- Building pandas for development now requires ``cython >= 0.23`` (:issue:`14831`)
Expand Down
15 changes: 3 additions & 12 deletions pandas/computation/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,13 @@
try:
import numexpr as ne
ver = ne.__version__
_NUMEXPR_INSTALLED = ver >= LooseVersion('2.1')
_NUMEXPR_INSTALLED = ver >= LooseVersion('2.4.6')

# we specifically disallow 2.4.4 as
# has some hard-to-diagnose bugs
if ver == LooseVersion('2.4.4'):
_NUMEXPR_INSTALLED = False
warnings.warn(
"The installed version of numexpr {ver} is not supported "
"in pandas and will be not be used\n".format(ver=ver),
UserWarning)

elif not _NUMEXPR_INSTALLED:
if not _NUMEXPR_INSTALLED:
warnings.warn(
"The installed version of numexpr {ver} is not supported "
"in pandas and will be not be used\nThe minimum supported "
"version is 2.1\n".format(ver=ver), UserWarning)
"version is 2.4.6\n".format(ver=ver), UserWarning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test for this i think

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Addressed in f225598.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and fixed a typo in 7a275ce


except ImportError: # pragma: no cover
pass
Expand Down