Require numexpr 2.6.2 #15382
Closed
Require numexpr 2.6.2 #15382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FrancescAlted maybe i was not clear on my earlier comment not requiring latest versions |
|
Ok. My first thought was requiring the newest numexpr version, which should be quite spread by the time that pandas reaches 0.20, but I agree that could be too aggresive. Closing in favor of PR #15383. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis addresses #15213. Numexpr 2.6.2 has wheels for all major platforms already, and although conda is still at 2.6.1, the fixes in 2.6.2 makes it strongly recommended for everyone.