TST: Fix gbq integration tests. gbq._Dataset.dataset() would not return full results #15381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All gbq units tests passed on Travis on my fork : https://travis-ci.org/parthea/pandas/builds/201024038 |
Codecov Report
@@ Coverage Diff @@
## master #15381 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.01%
==========================================
Files 134 134
Lines 49357 49369 +12
==========================================
+ Hits 44632 44638 +6
- Misses 4725 4731 +6
Continue to review full report at Codecov.
|
|
is this need to be added to pandas-gbq? |
|
thanks @parthea |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
…rn full results This PR resolves an issue where `gbq._Dataset.datasets()` would not return all datasets under a Google BigQuery project. If `'nextPageToken'` is populated, then another `datasets().list()` request should be sent with `'pageToken'` set to collect more results. In the past few days, additional datasets were added under the Google BigQuery project id used by pandas as part of the following github project : https://github.com/pydata/pandas-gbq . The addition of datasets caused many gbq unit tests to fail because in function `clean_gbq_environment()`, we check to see if the dataset exists using the incomplete results from `gbq._Dataset.datasets()` before we attempt to delete it. Author: Anthonios Partheniou <[email protected]> Closes pandas-dev#15381 from parthea/fix-broken-gbq-unit-tests and squashes the following commits: 61bc1e7 [Anthonios Partheniou] TST: Fix gbq tests. gbq.dataset()/gbq.tables would not return full results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis PR resolves an issue where
gbq._Dataset.datasets()would not return all datasets under a Google BigQuery project.If
'nextPageToken'is populated, then anotherdatasets().list()request should be sent with'pageToken'set to collect more results.In the past few days, additional datasets were added under the Google BigQuery project id used by pandas as part of the following github project : https://github.com/pydata/pandas-gbq . The addition of datasets caused many gbq unit tests to fail because in function
clean_gbq_environment(), we check to see if the dataset exists using the incomplete results fromgbq._Dataset.datasets()before we attempt to delete it.https://github.com/pandas-dev/pandas/blob/master/pandas/tests/io/test_gbq.py#L218