-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fixed handling of non-list value_vars in melt #15351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
33728de
BUG: Fixed handling of non-list value_vars in melt
d4c5da3
Improved type checking and tests. Added whatsnew note.
jbradt 7406222
Fixed formatting. Added comment with issue number to test.
455a310
Tested types when using MultiIndex to ensure they are lists.
70d7256
Merge branch 'master' into fix-melt
jbradt 129d531
Moved binary operators to satisfy flake8
20159c1
Changed exception classes to ValueError.
e907135
Split test into two parts
3038f64
Merge remote-tracking branch 'upstream/master' into fix-melt
a2f2510
Changed to tm.assertRaisesRegexp for Python 2 compat.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,19 @@ def test_value_vars(self): | |
columns=['id1', 'id2', 'variable', 'value']) | ||
tm.assert_frame_equal(result4, expected4) | ||
|
||
def test_value_vars_types(self): | ||
expected = DataFrame({'id1': self.df['id1'].tolist() * 2, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add the issue number as a comment |
||
'id2': self.df['id2'].tolist() * 2, | ||
'variable': ['A'] * 10 + ['B'] * 10, | ||
'value': (self.df['A'].tolist() + | ||
self.df['B'].tolist())}, | ||
columns=['id1', 'id2', 'variable', 'value']) | ||
|
||
for type_ in (tuple, list, np.array): | ||
result = melt(self.df, id_vars=['id1', 'id2'], | ||
value_vars=type_(('A', 'B'))) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_custom_var_name(self): | ||
result5 = melt(self.df, var_name=self.var_name) | ||
self.assertEqual(result5.columns.tolist(), ['var', 'value']) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put
TypeError
in double-back quotes